[Openmp-commits] [PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

Matt Arsenault via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Dec 20 13:10:08 PST 2021


arsenm added a comment.

In D109885#3203444 <https://reviews.llvm.org/D109885#3203444>, @JonChesterfield wrote:

> In D109885#3203412 <https://reviews.llvm.org/D109885#3203412>, @arsenm wrote:
>
>> We should have versioned libraries and well defined ABI breaks. The build should know what runtime versions it requires and account when searching
>
> If we're playing that game, ROCm should be strictly an extension of upstream LLVM, such that code which accidentally or intentionally picks up parts of ROCm while expecting parts of trunk runs correctly. I'd be happy with the easier objective of making it difficult to accidentally splice together parts of different toolchains at runtime.

ROCm has as much to do with llvm as the linux kernel does. The compiler and runtime version should not be so tightly linked / the runtime so unstable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109885/new/

https://reviews.llvm.org/D109885



More information about the Openmp-commits mailing list