[Openmp-commits] [PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

Thu Dec 16 11:29:22 PST 2021

arsenm added a comment.

In D109885#3198290 <https://reviews.llvm.org/D109885#3198290>, @JonChesterfield wrote:

> In D109885#3198232 <https://reviews.llvm.org/D109885#3198232>, @arsenm wrote:
>
>> Dropping the default install location from the default search hint is entirely unreasonable
>
> That seems to be the feature request, though I haven't gone through the jira web to work out what's going on here.

This isn't a feature, it's the introduction of a bug. It degrades the usability of the build. If you want an explicit version, that's what the search order process is for.

> We can either have opt-in to somewhere other than CMAKE_INSTALL_PREFIX, which I think Ethan's suggestion does (not clear whether PATH between the two variables is semantically important), or we could have opt-out for people who want to be sure they aren't picking up something in /opt/rocm.

This isn't how search paths work. By default, the fallback should always find the default location

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109885/new/

https://reviews.llvm.org/D109885