[Openmp-commits] [PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

[Ethan Stewart via Phabricator via Openmp-commits]

estewart08 added a comment.

In D109885#3194819 <https://reviews.llvm.org/D109885#3194819>, @ronlieb wrote:

> @estewart08 thoughts on a good CMAKE variable to allow users to define equivalent of /opt/rocm  ?   and not use environment variable inside the cmake file.

I would be ok with the following, without the check for ENV{ROCM_PATH}. The user has the option to set -DROCM_PATH=$ROCM_PATH or -DCMAKE_PREFIX_PATH.

  find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATH ${ROCM_PATH})


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109885/new/

https://reviews.llvm.org/D109885