[Openmp-commits] [PATCH] D115980: [libomptarget][amdgpu][nfc] Make API harder to misimplement

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Dec 17 16:00:45 PST 2021


JonChesterfield created this revision.
JonChesterfield added reviewers: carlo.bertolli, ronlieb, jdoerfert, tianshilei1992, ye-luo, jhuber6, grokos.
Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
JonChesterfield requested review of this revision.
Herald added subscribers: openmp-commits, wdng.
Herald added a project: OpenMP.

Refactors the dlwrap.h header and then uses it to implement compiler
checks that the plugin implements the functions defined in omptargetplugin.h.

For symbols marked with EXPORT(), misspelled names, incorrect arity and type
errors are now detected at compile time. Either with errors immediately, or
warnings followed by failure to link. Motivated by an error in D115823 <https://reviews.llvm.org/D115823>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115980

Files:
  openmp/libomptarget/include/dlwrap.h
  openmp/libomptarget/plugins/amdgpu/src/rtl.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115980.395239.patch
Type: text/x-patch
Size: 26063 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20211218/7dfdec4c/attachment-0001.bin>


More information about the Openmp-commits mailing list