[Openmp-commits] [PATCH] D115966: [openmp][libomptarget][nfc] Infer types instead of duplicate and cast void

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Dec 17 14:22:25 PST 2021

JonChesterfield added inline comments.

Comment at: openmp/libomptarget/include/dlwrap.h:74
 // so that the function pointer call can be wrapped in library-specific code
+// DLWRAP_INITIALIZE() declares static functions:
JonChesterfield wrote:
> Without this or similar, including dlwrap.h from a file that doesn't use all the pieces errors about declared but missing static functions. I'm considering moving the non-dlwrap parts into a separate header but leaving that for a later patch.
I think the change to dlwrap is good in it's own right, we shouldn't have a header that is an error to include unless some macro in it is invoked and the INITIALIZE() call may be useful anyway. Got some other patches backing up on this so will land that separate to the libomptarget implementation change

  rG LLVM Github Monorepo



More information about the Openmp-commits mailing list