[Openmp-commits] [PATCH] D115966: [openmp][libomptarget][nfc Infer types instead of duplicate and cast void

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Dec 17 12:22:23 PST 2021


JonChesterfield created this revision.
JonChesterfield added reviewers: ye-luo, jdoerfert, carlo.bertolli, tianshilei1992.
Herald added subscribers: kerbowa, guansong, yaxunl, nhaehnle, jvesely.
JonChesterfield requested review of this revision.
Herald added subscribers: openmp-commits, sstefan1.
Herald added a project: OpenMP.

Replaces handwritten typedefs and casts via void* with types inferred
from declarations in omptargetplugins.h. Leaves unchanged a function with the
wrong type and register/unregister which follow a different pattern.

Rename a couple of pointer variables to match the api (missing _target_
Minor change made to dlwrap.h to use the type inference from it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115966

Files:
  openmp/libomptarget/include/dlwrap.h
  openmp/libomptarget/include/omptargetplugin.h
  openmp/libomptarget/plugins/amdgpu/dynamic_hsa/hsa.cpp
  openmp/libomptarget/plugins/cuda/dynamic_cuda/cuda.cpp
  openmp/libomptarget/src/device.cpp
  openmp/libomptarget/src/rtl.cpp
  openmp/libomptarget/src/rtl.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115966.395196.patch
Type: text/x-patch
Size: 18333 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20211217/2e8778e0/attachment-0001.bin>


More information about the Openmp-commits mailing list