[Openmp-commits] [PATCH] D115823: [openmp][libomptarget] Introduce and call createAsyncInfo

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added inline comments.


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:944
 
+  CUstream getStream(const int DeviceId, __tgt_async_info *AsyncInfo) const {
+    assert(AsyncInfo && "AsyncInfo is nullptr");
----------------
jdoerfert wrote:
> ye-luo wrote:
> > getStream should remain private. It leaks CUstream if put public.
> > getStream doesn't recreate AsyncInfo->Queue if it is not nullptr.
> > I would expect an error if createAsyncInfo.
> > So Please add a new public function instead of reusing getStream.
> I think my asyncmalloc patch makes it public too. 
> I think my asyncmalloc patch makes it public too. 

Then my concern applies to your patch as well. LOL


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115823/new/

https://reviews.llvm.org/D115823