[Openmp-commits] [PATCH] D115823: [openmp][libomptarget] Introduce and call createAsyncInfo

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Dec 15 12:14:52 PST 2021


JonChesterfield created this revision.
JonChesterfield added reviewers: jdoerfert, tianshilei1992, carlo.bertolli, grokos, bollu.
Herald added subscribers: kerbowa, guansong, yaxunl, nhaehnle, jvesely.
JonChesterfield requested review of this revision.
Herald added subscribers: openmp-commits, sstefan1.
Herald added a project: OpenMP.

At present, every async function is responsible for noticing it has
been passed a nullptr for async_info and initializing it. With this change,
a new api function is called to initialize async_info within libomptarget.

A subsequent change can then only call async functions when that construction
succeeded, at which point the init-if-passed-nullptr logic from the plugins
can be replaced with asserts.

Couple of typo fixes noticed while implementing. Builds on D96438 <https://reviews.llvm.org/D96438>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115823

Files:
  openmp/libomptarget/include/omptarget.h
  openmp/libomptarget/include/omptargetplugin.h
  openmp/libomptarget/plugins/amdgpu/src/rtl.cpp
  openmp/libomptarget/plugins/cuda/src/rtl.cpp
  openmp/libomptarget/plugins/exports
  openmp/libomptarget/src/device.cpp
  openmp/libomptarget/src/device.h
  openmp/libomptarget/src/omptarget.cpp
  openmp/libomptarget/src/rtl.cpp
  openmp/libomptarget/src/rtl.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115823.394637.patch
Type: text/x-patch
Size: 9003 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20211215/5ad22bdc/attachment.bin>


More information about the Openmp-commits mailing list