[Openmp-commits] [PATCH] D115454: [OpenMP] Add "not" to test dependencies.

[Michael Kruse via Phabricator via Openmp-commits]

Meinersbur added inline comments.


================
Comment at: openmp/cmake/OpenMPTesting.cmake:68
   endif()
   set(OPENMP_NOT_EXECUTABLE ${LLVM_RUNTIME_OUTPUT_INTDIR}/not)
 endif()
----------------
jdenny wrote:
> Do you know why `not` and `FileCheck` are handled differently here?  It might be that D95689 simply overlooked `not`.  @tianshilei1992?
> 
> I'm not sure if this discrepancy is relevant to the problem you're trying to fix, so maybe it should be addressed separately.
@tianshilei1992 might be the best to answer this question. However, by the motivation D95689, it seems that  `LLVM_INSTALL_TOOLCHAIN_ONLY` applies to `not` and `FileCheck` at the same time. hence checking the existence of one implies the existence of the other.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115454/new/

https://reviews.llvm.org/D115454