[Openmp-commits] [PATCH] D115454: [OpenMP] Add "not" to test dependencies.

Michael Kruse via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Dec 9 09:59:58 PST 2021


Meinersbur created this revision.
Meinersbur added reviewers: tianshilei1992, jdenny, JonChesterfield, arsenm, ronl, jhuber6, jyu2.
Meinersbur added a project: OpenMP.
Herald added subscribers: guansong, yaxunl, mgorny.
Meinersbur requested review of this revision.
Herald added subscribers: sstefan1, wdng.
Herald added a reviewer: jdoerfert.

The `not` program is used to test executions prefixed with `%libomptarget-run-fail-`. Currently `not` is not used for libomp tests, but might be used in the future and its dependency does not add any additional burden over the already established `FileCheck` dependency.

Required to add libomptarget testing to the Phabricator pre-merge check (see https://github.com/google/llvm-premerge-checks/issues/368)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115454

Files:
  openmp/cmake/OpenMPTesting.cmake


Index: openmp/cmake/OpenMPTesting.cmake
===================================================================
--- openmp/cmake/OpenMPTesting.cmake
+++ openmp/cmake/OpenMPTesting.cmake
@@ -196,14 +196,14 @@
         ${comment}
         ${ARG_UNPARSED_ARGUMENTS}
         EXCLUDE_FROM_CHECK_ALL
-        DEPENDS clang FileCheck ${ARG_DEPENDS}
+        DEPENDS clang FileCheck not ${ARG_DEPENDS}
         ARGS ${ARG_ARGS}
       )
     else()
       add_lit_testsuite(${target}
         ${comment}
         ${ARG_UNPARSED_ARGUMENTS}
-        DEPENDS clang FileCheck ${ARG_DEPENDS}
+        DEPENDS clang FileCheck not ${ARG_DEPENDS}
         ARGS ${ARG_ARGS}
       )
     endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115454.393204.patch
Type: text/x-patch
Size: 676 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20211209/21f612a1/attachment-0001.bin>


More information about the Openmp-commits mailing list