[Openmp-commits] [PATCH] D115279: [OpenMP][AMDGPU] Switch host-device memory copy to asynchronous version
Carlo Bertolli via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Wed Dec 8 05:07:47 PST 2021
carlo.bertolli added a comment.
In D115279#3178711 <https://reviews.llvm.org/D115279#3178711>, @JonChesterfield wrote:
> Yes, should revert and update the dlopen HSA source. Apologies for not checking this builds before committing it.
> I don't know whether there's more ritual to to around whether it's already pinned - @carlo.bertolli did you look into testing if the memory is already pinned before doing so? Particularly interested if already pinned is a reason for lock to fail
I have not tried with memory that has already been locked, but I will. In any case, with this patch, if locking fails, then we revert to malloc+lock+unlock+free. This is not ideal, and this case is added for other reasons, but it should be supporting the case.
In D115279#3178496 <https://reviews.llvm.org/D115279#3178496>, @ye-luo wrote:
> hsa_amd_memory_lock and hsa_amd_memory_unlock are missing in hsa.cpp and hsa_ext_amd.h as well under openmp/libomptarget/plugins/amdgpu/dynamic_hsa
It is an AMD HSA extension. It builds fine on a system with rocm 4.5. What kind of problem are you seeing?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the Openmp-commits