[Openmp-commits] [PATCH] D114501: [OpenMP][test] Regression tests for OpenMPIRBuilder.

Wed Dec 8 02:58:09 PST 2021

Leporacanthicus accepted this revision.
Leporacanthicus added a comment.
This revision is now accepted and ready to land.

LGTM. Just one nit-pick, there's a few new tests that test some pretty specific things. Would be nice to have a line or three about what they actually test - e.g "Tests that destructor is not called until after OpenMP section has completed".

================
Comment at: openmp/runtime/test/parallel/omp_dtor_parallel_dtor.cpp:9
+#include <omp.h>
+
+struct Destructible {
----------------
Would be nice to describe what the test is actually testing. 

Although some of the other tests do not describe the purpose either!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114501/new/

https://reviews.llvm.org/D114501