[Openmp-commits] [PATCH] D115144: [openmp][amdgpu] Disable tests requiring USM on amdgcn

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Dec 6 03:59:28 PST 2021

JonChesterfield created this revision.
JonChesterfield added a reviewer: ronlieb.
Herald added subscribers: guansong, t-tye, tpr, dstuttard, yaxunl, kzhuravl.
JonChesterfield requested review of this revision.
Herald added subscribers: openmp-commits, sstefan1, wdng.
Herald added a reviewer: jdoerfert.
Herald added a project: OpenMP.

These tests tend to hang or crash on hardware that doesn't
support USM. Disabling them helps diagnose other issues. To safely
enable we require a means of testing whether USM is expected to work.

  rG LLVM Github Monorepo



Index: openmp/libomptarget/test/lit.cfg
--- openmp/libomptarget/test/lit.cfg
+++ openmp/libomptarget/test/lit.cfg
@@ -78,6 +78,8 @@
   except ValueError:
     # If the architecture is invalid, assume it is supported.
     supports_unified_shared_memory = True
+if config.libomptarget_current_target.startswith('amdgcn'):
+    supports_unified_shared_memory = False
 if supports_unified_shared_memory:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115144.392018.patch
Type: text/x-patch
Size: 530 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20211206/b14d1a6c/attachment.bin>

More information about the Openmp-commits mailing list