[Openmp-commits] [PATCH] D113824: [OpenMP] Fix custom state machine if have reduction
Joel E. Denny via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Thu Dec 2 08:39:57 PST 2021
jdenny added a comment.
In D113824#3165416 <https://reviews.llvm.org/D113824#3165416>, @jdoerfert wrote:
> I didn't see this patch before, sorry.
> D114802 <https://reviews.llvm.org/D114802> was the right fix.
Glad someone fixed it correctly. But that patch doesn't add a regression test. Is there one somewhere? Should I commit the test addition from the current patch?
> I am not sure how this fixes anything to be honest.
> This `foldKernelFnAttribute(A, "");` in particular is beyond me.
I'll remove it.
Is the __OMP_RTL_ATTRS addition in the current patch useful?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the Openmp-commits