[Openmp-commits] [PATCH] D113824: [OpenMP] Fix custom state machine if have reduction

[Joel E. Denny via Phabricator via Openmp-commits]

jdenny added a comment.

In D113824#3165416 <https://reviews.llvm.org/D113824#3165416>, @jdoerfert wrote:

> I didn't see this patch before, sorry.
>
> D114802 <https://reviews.llvm.org/D114802> was the right fix.

Glad someone fixed it correctly.  But that patch doesn't add a regression test.  Is there one somewhere?  Should I commit the test addition from the current patch?

> I am not sure how this fixes anything to be honest.
> This `foldKernelFnAttribute(A, "");` in particular is beyond me.

I'll remove it.

Is the __OMP_RTL_ATTRS addition in the current patch useful?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113824/new/

https://reviews.llvm.org/D113824