[Openmp-commits] [PATCH] D107496: [OpenMP] Fix task wait doesn't work as expected in serialized team

Andrey Churbanov via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Aug 31 02:52:49 PDT 2021


AndreyChurbanov accepted this revision.
AndreyChurbanov added a comment.
This revision is now accepted and ready to land.

LGTM with one nit.



================
Comment at: openmp/runtime/src/kmp_tasking.cpp:823
+  bool ret =
+      !(taskdata->td_flags.team_serial || taskdata->td_flags.tasking_ser);
+  ret = ret || flags.proxy == TASK_PROXY ||
----------------
Why not use `flags` here instead of `taskdata->td_flags`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107496/new/

https://reviews.llvm.org/D107496



More information about the Openmp-commits mailing list