[Openmp-commits] [PATCH] D108528: [OpenMP][Offloading] Add support for event related interfaces

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added inline comments.


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:132
 
+void *createEvent() {
+  CUevent Event = nullptr;
----------------
tianshilei1992 wrote:
> ye-luo wrote:
> > I just realize that this one needs to be
> > int createEvent(void** createEvent)
> > and the return code needs to indicate the success/failure of cuEventCreate call.
> > 
> > This is probably my last concern.
> That's a good one. Done.
Should the return type int as others?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108528/new/

https://reviews.llvm.org/D108528