[Openmp-commits] [PATCH] D108528: [OpenMP][Offloading] Add support for event related interfaces

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 marked 12 inline comments as done.
tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:1398
+    // API document, that argument has to be 0x0.
+    CUresult Err = cuStreamWaitEvent(Stream, Event, 0);
+    if (Err != CUDA_SUCCESS) {
----------------
ye-luo wrote:
> I feel better to avoid hard-code 0.
> better to check if CU_EVENT_WAIT_DEFAULT exists, if not, set CU_EVENT_WAIT_DEFAULT to 0.
`CU_EVENT_WAIT_DEFAULT` is a enum value. We cannot check if it exists.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108528/new/

https://reviews.llvm.org/D108528