[Openmp-commits] [PATCH] D106510: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in runtime (2/2)

[George Rokos via Phabricator via Openmp-commits]

grokos added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:200
     auto &HT = *LR.Entry;
-    assert(HT.getRefCount() > 0 && "expected existing RefCount > 0");
-    if (UpdateRefCount)
+    IsNew = false;
+    const char *RefCountAction;
----------------
`IsNew` is already `false` at this point, no need to reassign.


================
Comment at: openmp/libomptarget/src/device.cpp:343
+      else {
+        HT.decRefCount(UseHoldRefCount);
+        RefCountAction = " (reset)";
----------------
Currently, we don't decrement the RefCount at this point. Is this a bug in the existing code?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106510/new/

https://reviews.llvm.org/D106510