[Openmp-commits] [PATCH] D104696: [AMDGPU][Libomptarget] Delete g_atl_machine global

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/data.cpp:24
+  hsa_status_t err = hsa_amd_memory_pool_allocate(MemoryPool, size, 0, ptr);
+  DEBUG_PRINT("Malloced [CPU %d] %p\n", DeviceId, *ptr);
 
----------------
ikelarev wrote:
> Debug build is broken here:
> 
> data.cpp:24:41: error: use of undeclared identifier 'DeviceId'
>   DEBUG_PRINT("Malloced [CPU %d] %p\n", DeviceId, *ptr);
>                                         ^
Thanks for reporting! Simple fix at ba8547775b0c83ea. Something of a reminder that the files under impl are still using a different debug print mechanism to rtl.cpp.

@pushpinder we should delete the DEBUG_PRINT statements where reasonable and convert the survivors to the DP() macro.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104696/new/

https://reviews.llvm.org/D104696