[Openmp-commits] [PATCH] D108528: [OpenMP][Offloading] Add support for event related interfaces

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added a comment.

In D108528#2961216 <https://reviews.llvm.org/D108528#2961216>, @JonChesterfield wrote:

> In D108528#2961204 <https://reviews.llvm.org/D108528#2961204>, @jdoerfert wrote:
>
>> Wait, attach a wait into the AsyncObj stream to avoid anything added after runs before the event is fulfilled.
>
> Would 'fulfilled' mean the kernels that were launched before it have all completed?
>
> That probably involves a barrier packet on amdgpu. Needs to go on the same HSA queue as the associated kernels, which is probably what will be in the async info.
>
>> Sync, block until the event is fulfilled.
>
> That is probably doable without poking at the HSA queue for amdgpu but I'm not certain of it.
>
> Can I invoke debug printing as a justification for passing the async object to all of them? I probably want to be able to tell what the lifecycle of a given event is in terms of what functions it was passed to.

It is actually meaningless. When you  pass in an event, this event may or may not have been recorded on the AsyncInfo->Queue passed in. It is not one-to-one mapping.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108528/new/

https://reviews.llvm.org/D108528