[Openmp-commits] [PATCH] D108528: [OpenMP][Offloading] Add support for event related interfaces

Mon Aug 23 13:30:28 PDT 2021

ye-luo added inline comments.

================
Comment at: openmp/libomptarget/include/omptargetplugin.h:160
+// {
+void *__tgt_rtl_create_event(int32_t ID, __tgt_async_info *AsyncInfo);
+
----------------
tianshilei1992 wrote:
> ye-luo wrote:
> > Please remove AsyncInfo which is not used.
> I would keep it for compatibility consideration. Note that we are not writing a library only for CUDA. There might be programming models requiring the queue.
If you think compatibility consideration is real now, please provide details of one case of need. It is not about CUDA, but it is better to avoid hypothetical needs.

Additional unused arguments adds confusion and cost maintenance.

With the minimal arguments,
If a real needs shows up, it is easy to adapt and expand the list arguments.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108528/new/

https://reviews.llvm.org/D108528