[Openmp-commits] [PATCH] D108528: [OpenMP][Offloading] Add support for event related interfaces

[George Rokos via Phabricator via Openmp-commits]

grokos added a comment.

Typos. LGTM, waiting for @ye-luo to comment on the patch.



================
Comment at: openmp/libomptarget/include/omptargetplugin.h:158
+// 4) Call __tgt_rtl_sync_event to sync the event. It is expected to block the
+// thread calling the function. 5) Destroy the event (__tgt_rtl_destroy_event).
+// {
----------------
New line between 4) and 5)


================
Comment at: openmp/libomptarget/src/device.h:292
+  /// Wait for an event. This function can be blocking or non-blocking,
+  /// depending on the implmentation. It is expected to set a dependenc on the
+  /// event such that corresponding operations shall only start once the event
----------------
dependency


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108528/new/

https://reviews.llvm.org/D108528