[Openmp-commits] [PATCH] D104418: [OpenMP][Offloading] Fixed data race in libomptarget caused by async data movement

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sun Aug 22 19:46:37 PDT 2021


tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:100
 
-int DeviceTy::disassociatePtr(void *HstPtrBegin) {
+int DeviceTy::disassociatePtr(void *HstPtrBegin, AsyncInfoTy &AsyncInfo) {
   DataMapMtx.lock();
----------------
The change of the function signature would not be required if we don't need to pass `AsyncInfo` to the plugin. Potentially we can wrap the native event into a struct and the object will call `destroyEvent` in its destructor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104418/new/

https://reviews.llvm.org/D104418



More information about the Openmp-commits mailing list