[Openmp-commits] [PATCH] D108488: [OpenMP] [test] Fix intermittent omp_get_wtime.c test failures

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Aug 20 15:07:32 PDT 2021


JonChesterfield accepted this revision.
JonChesterfield added a comment.

Complicated, but robust wall clock timing was always going to be complicated. This looks reasonable and more robust that the current one.

Timing usually involves a fixed size integer that occasionally overflows so a little care is needed around end - start. I don't know how that works out if the return type is a double, maybe it abruptly goes back to zero, but it's hard to guess at what point. However wtime() is specified to return a floating point value so here we are.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108488/new/

https://reviews.llvm.org/D108488



More information about the Openmp-commits mailing list