[Openmp-commits] [PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:2383
+defm openmp_extensions: BoolFOption<"openmp-extensions",
+  LangOpts<"OpenMPExtensions">, DefaultFalse,
+  PosFlag<SetTrue, [CC1Option, NoArgumentUnused],
----------------
jdenny wrote:
> ABataev wrote:
> > Why do you want to disable it by default?
> I thought that's what we agreed upon.
> 
> I'm personally happy if, in general, all features are enabled by default and users opt out by requesting strict conformance, but Clang doesn't do that today even for features from newer OpenMP standards.  Should it do so for extensions, which appear in no standard?
> 
> What would you prefer?
I would enable it by default, as it may help users in some cases unless there are no other strong opinions.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5774-5776
+      if (Args.hasFlag(options::OPT_fopenmp_extensions,
+                       options::OPT_fno_openmp_extensions, /*Default=*/false))
+        CmdArgs.push_back("-fopenmp-extensions");
----------------
jdenny wrote:
> ABataev wrote:
> > Do we still need this?
> I tried removing these, but then the driver doesn't pass `-fopenmp-extensions` to the front end.  Am I doing something wrong?
Ah, yes, still need to forward the option from driver to the frontend


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106509/new/

https://reviews.llvm.org/D106509