[Openmp-commits] [PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: clang/docs/ClangCommandLineReference.rst:2042-2044
+.. option:: -fopenmp-extensions, -fno-openmp-extensions
+
+Enable all Clang extensions for OpenMP directives and clauses.
----------------
Default value?


================
Comment at: clang/include/clang/Driver/Options.td:2383
+defm openmp_extensions: BoolFOption<"openmp-extensions",
+  LangOpts<"OpenMPExtensions">, DefaultFalse,
+  PosFlag<SetTrue, [CC1Option, NoArgumentUnused],
----------------
Why do you want to disable it by default?


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5774-5776
+      if (Args.hasFlag(options::OPT_fopenmp_extensions,
+                       options::OPT_fno_openmp_extensions, /*Default=*/false))
+        CmdArgs.push_back("-fopenmp-extensions");
----------------
Do we still need this?


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5812-5814
+    if (Args.hasFlag(options::OPT_fopenmp_extensions,
+                     options::OPT_fno_openmp_extensions, /*Default=*/false))
+      CmdArgs.push_back("-fopenmp-extensions");
----------------
Same, do we still need this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106509/new/

https://reviews.llvm.org/D106509