[Openmp-commits] [PATCH] D106960: [OffloadArch] Library to query properties of current offload archicture

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

T



================
Comment at: llvm/lib/OffloadArch/amdgpu/vendor_specific_capabilities.cpp:25
+//
+#include "hsa-subset.h"
+#include <dlfcn.h>
----------------
yaxunl wrote:
> It would be much simpler to use HIP API to get device name and capabilities e.g. gfx906:xnack+:sramecc-
> 
> https://github.com/ROCm-Developer-Tools/HIP/blob/rocm-4.2.x/samples/1_Utils/hipInfo/hipInfo.cpp
> 
> It will work on both Linux and Windows. On Linux the availability of HIP runtime is the same as HSA runtime. On Windows HIP runtime is shipped with display driver, whereas HSA runtime is not available.
> On Linux the availability of HIP runtime is the same as HSA runtime

This is probably not true. If ROCm is installed somewhere, both HIP and HSA runtimes are available. If building from source, HSA is much quicker and easier to build than the HIP runtimes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106960/new/

https://reviews.llvm.org/D106960