[Openmp-commits] [PATCH] D107698: [libomptarget][amdgpu] use --allow-shlib-undefined to link on FreeBSD

[Dimitry Andric via Phabricator via Openmp-commits]

dim removed a subscriber: sstefan1.
dim added a comment.

In D107698#2932934 <https://reviews.llvm.org/D107698#2932934>, @JonChesterfield wrote:

> That'll work. It means freebsd gets less link time sanity checking though.
>
> The correct fix might be to use a platform abstraction over environment access. There's probably one in the llvm libraries we can use.

Well, the `environ` usage actually comes from `llvm/lib/Support`. :) But it's a known problem; typically shared libraries don't really have their own `environ`, it's supposed to be provided by the main program loading those shared libraries. But glibc solves this by providing the symbol itself as a weak alias. In https://reviews.freebsd.org/D30842 there's a discussion going on about something similar for FreeBSD's libc, but it's not decided yet...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107698/new/

https://reviews.llvm.org/D107698