[Openmp-commits] [PATCH] D107656: [OpenMP] Use events and taskyield in target nowait task to unblock host threads

[Ravi Narayanaswamy via Phabricator via Openmp-commits]

RaviNarayanaswamy added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:546
+  } else {
+    AsyncInfo.setEventSupported(false);
+    return OFFLOAD_SUCCESS;
----------------
Isn't this initialized to false when the AsyncInfo is created.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:73
   }
   return Result;
 }
----------------
ye-luo wrote:
> RaviNarayanaswamy wrote:
> > Result is not set on all paths
> When leaving line 62, the return value is OFFLOAD_SUCCESS as line 28 sets it
I missed that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107656/new/

https://reviews.llvm.org/D107656