[Openmp-commits] [PATCH] D107656: [OpenMP] Use events and taskyield in target nowait task to unblock host threads

Fri Aug 6 10:42:22 PDT 2021

tianshilei1992 added a comment.

In D107656#2931676 <https://reviews.llvm.org/D107656#2931676>, @ye-luo wrote:

> I think a target task is an explicit task but it s not clear to me that if it is an tied task. probably that is the reason of failing TSC.
>
> If my understanding of the situation is correct, I'm wondering if we can claim target task as untied and then got new tasks scheduled?

A regular task by default is tied. That's why in __kmpc_omp_target_task_alloc` we set it to untied if hidden helper task is enabled. The spec says:

> Target task: A mergeable and untied task that is generated by a device construct or a call to a device memory routine and that coordinates activity between the current device and the target device.

So I think we need to set it to untied no matter whether hht is enabled.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107656/new/

https://reviews.llvm.org/D107656