[Openmp-commits] [PATCH] D84557: [OpenMP][Tests] Enable nvptx64 testing for most libomptarget tests

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

I'm having second thoughts about this.

It works because clang searches LIBRARY_PATH first when looking for the deviceRTL. That means a system that has LIBRARY_PATH accidentally/incidentally pointing to a different toolchain to the one that contains the running clang will pick up the wrong library. That's relatively likely to fail in opaque fashion.

Would you accept changing the tests to pass the exact location of the deviceRTL to use instead? The command line flag is already there, and wins out over LIBRARY_PATH. Closely related, I'd like to delete the behaviour of checking the LIBRARY_PATH to find the deviceRTL to use with a particular clang, so that only the people who consciously choose to point it at a different device runtime experience the result. LIBRARY_PATH is too easy to set accidentally and/or forget about.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84557/new/

https://reviews.llvm.org/D84557