[Openmp-commits] [PATCH] D99803: [openmp] Add OMPT initialization in libomptarget
Joachim Protze via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Wed Aug 4 08:49:13 PDT 2021
protze.joachim accepted this revision.
protze.joachim added a comment.
The fixed version LGTM
================
Comment at: openmp/libomptarget/src/rtl.cpp:203
+ }
+ }
+ ompt_initialized = true;
----------------
hbae wrote:
> protze.joachim wrote:
> > hbae wrote:
> > > Can we also turn if off when `!libomp_start_tool`?
> > Do you mean the `ompt_initialized` variable? I think, we just can remove this variable. LoadRTLs should only be called once during the execution.
> >
> > All other code just looks at `ompt_target_enabled`, which is 0 if `!libomp_start_tool`.
> Looks OK for now.
> We may be able to add any clean-up changes in the follow-up patches.
The `ompt_initialized` variable is gone now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99803/new/
https://reviews.llvm.org/D99803
More information about the Openmp-commits
mailing list