[Openmp-commits] [PATCH] D99803: [openmp] Add OMPT initialization in libomptarget

Hansang Bae via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Aug 2 13:28:39 PDT 2021


hbae accepted this revision.
hbae added inline comments.
This revision is now accepted and ready to land.


================
Comment at: openmp/libomptarget/src/rtl.cpp:203
+      }
+    }
+    ompt_initialized = true;
----------------
protze.joachim wrote:
> hbae wrote:
> > Can we also turn if off when `!libomp_start_tool`?
> Do you mean the `ompt_initialized` variable? I think, we just can remove this variable. LoadRTLs should only be called once during the execution.
> 
> All other code just looks at `ompt_target_enabled`, which is 0 if `!libomp_start_tool`.
Looks OK for now.
We may be able to add any clean-up changes in the follow-up patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99803/new/

https://reviews.llvm.org/D99803



More information about the Openmp-commits mailing list