[Openmp-commits] [PATCH] D101265: [OpenMP][CMake] Use in-project clang as CUDA->IR compiler.

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

In D101265#2727998 <https://reviews.llvm.org/D101265#2727998>, @Meinersbur wrote:

> In D101265#2724364 <https://reviews.llvm.org/D101265#2724364>, @tianshilei1992 wrote:
>
>> Or let me put it in this way, is there any other project (such as lld) that when it is in LLVM_ENABLE_PROJECTS along with clang, it is actually built by the clang just built? If yes, I'll be totally fine with your change.
>
>
>
> 1. Thread-sanitizer (compiler-rt) compiles libcxx with `$<TARGET_FILE:clang>` to get a thread-sanitized C++ standard library.
> 2. libtooling uses just-built clang for AST introspection
> 3. Polly uses just-built clang-tidy to check whether its correctly formatted.
> 4. libc uses just-built clang-tidy for some linting.

Thanks for the information. Now I'm okay with the change. @protze.joachim 's comment sounds reasonable. `LIBOMPTARGET_NVPTX_CUDA_COMPILER` is a path to `clang` so it's different from the target `clang`. `llvm-link` as well.  Others LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101265/new/

https://reviews.llvm.org/D101265