[Openmp-commits] [PATCH] D101498: [OpenMP] Test unified shared memory tests only on systems that support it.

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

In D101498#2727812 <https://reviews.llvm.org/D101498#2727812>, @Meinersbur wrote:

> In D101498#2724916 <https://reviews.llvm.org/D101498#2724916>, @protze.joachim wrote:
>
>> The logic to identify whether certain features are supported for testing is in `openmp/cmake/OpenMPTesting.cmake`.
>
> The file does not contain target-specific features, but "Set up testing infrastructure" (According to the comment in the top-level CMakeLists.txt). At the point when it is invoked, libomptarget has not been processed yet, making it impossible to determine target-dependent features.

Ok, I'd still prefer that we keep the logic to determine the feature support in CMake, where we have access to all CMake variables (without passing them into lit one by one).

Kelvin reported a different list of tests as unexpectedly passing in D101326 <https://reviews.llvm.org/D101326>. His list includes api.c.
On my system (Tesla V100/sm_70), `close_manual.c` succeeds, while the others don't.

For me it looks like `REQUIRES: unified_shared_memory` might not be sharp enough to mark those tests.
Probably we should go with `UNSUPPORTED: sm_35, sm_37, sm_50, sm_52, sm_53, sm_60,  sm_61, sm_62` and set the value for the architecture available in the system.



================
Comment at: openmp/libomptarget/test/unified_shared_memory/close_enter_exit.c:5
 // UNSUPPORTED: clang-6, clang-7, clang-8, clang-9
 // XFAIL: nvptx64-nvidia-cuda
 
----------------
If the requires works, this line should go away


================
Comment at: openmp/libomptarget/test/unified_shared_memory/close_modifier.c:2
 // RUN: %libomptarget-compile-run-and-check-generic
 // XFAIL: nvptx64-nvidia-cuda
 
----------------
If the requires works, this line should go away


================
Comment at: openmp/libomptarget/test/unified_shared_memory/shared_update.c:4
+// REQUIRES: unified_shared_memory
 // XFAIL: nvptx64-nvidia-cuda
 
----------------
If the requires works, this line should go away


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101498/new/

https://reviews.llvm.org/D101498