[Openmp-commits] [PATCH] D101509: An attempt to abandon omptarget out-of-tree builds.

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

In D101509#2724846 <https://reviews.llvm.org/D101509#2724846>, @mgorny wrote:

> Is this going to block all direct builds of openmp or just these that don't have an LLVM source tree handy?

This is aimed at libomptarget, libopenmp can still build without llvm, provided it excludes the target part.

> Also, do you really need *sources* and not just compiled libLLVM?

I think, for this part, binaries would do. There are various hazards around getting compiled libraries that match the current compiler settings, but they're solvable. Note though that libomptarget already requires the llvm source (for shared magic numbers, mostly)



================
Comment at: openmp/CMakeLists.txt:66
 endif()
 
 if (NOT LIBOMPTARGET_LLVM_INCLUDE_DIRS)
----------------
Do we still have a definition of LIBOMPTARGET_LLVM_INCLUDE_DIRS with this block deleted? Looks unset on one side of the branch from L7 to me, but maybe hitting the fatal error further down catches that path. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101509/new/

https://reviews.llvm.org/D101509