[Openmp-commits] [PATCH] D101173: [OpenMP] Changes to enable MSVC ARM64 build of libomp

Wed Apr 28 15:58:41 PDT 2021

JonChesterfield added a comment.

In D101173#2724204 <https://reviews.llvm.org/D101173#2724204>, @pulidocr wrote:

> @jdoerfert @natgla Sounds great, I'd also like to attend next meeting.
>
> In D101173#2722833 <https://reviews.llvm.org/D101173#2722833>, @JonChesterfield wrote:
>
>> If I understand correctly, we presently have neither windows nor aarch64 working.
>
> I'm confused about this statement. Does this mean that libomp is not available for Windows at all, for any architecture? I'm confused because I see libomp.dll as a part of the pre-built Windows binaries that users can download, for at least for x64 which I have installed.

That was my understanding, but not surprised to be wrong. I'm almost certain libomptarget doesn't work on windows. Libomp.dll suggests that part does build for windows, so given that information I'd then assume it passes tests too.

This patch does however read like two orthogonal sets of fixes, some for windows (which might mean msvc? Code says windows, description says msvc), some for aarch64.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101173/new/

https://reviews.llvm.org/D101173