[Openmp-commits] [PATCH] D99656: [AMDGPU][OpenMP] Enable Libomptarget runtime tests

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

Patch is much improved by Joachim's refactor!

Looks good to me, will leave the check box to someone who has edited these tests before. Bringing printf online looks like a useful thing to do soon.



================
Comment at: openmp/libomptarget/test/unified_shared_memory/close_enter_exit.c:4
 // UNSUPPORTED: clang-6, clang-7, clang-8, clang-9
-// XFAIL: nvptx64-nvidia-cuda
+// XFAIL: nvptx64-nvidia-cuda, amdgcn-amd-amdhsa
 
----------------
Inconsistent with above. I.e. XFAIL on two lines or one XFAIL with comma delimited. No preference either way here, but probably stay with a convention


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99656/new/

https://reviews.llvm.org/D99656