[Openmp-commits] [PATCH] D100181: [OpenMP] [OMPD] [1/6] Implementation of OMPD debugging library - libompd. Code changes in openmp/runtime to support libompd.

[Hansang Bae via Phabricator via Openmp-commits]

hbae added inline comments.


================
Comment at: openmp/runtime/src/include/omp-tools.h.var:1307
+ompd_rc_t ompd_get_state(ompd_thread_handle_t *thread_handle,
+                         ompd_word_t *state, ompt_wait_id_t *wait_id);
+
----------------
We need to use `ompd_wait_id_t`.


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:1343
         OMPT_GET_FRAME_ADDRESS(0);
+#if OMPD_SUPPORT
+    OMPT_CUR_TASK_INFO(this_thr)->scheduling_parent =
----------------
Why do we need scheduling task for implicit tasks while we don't call it task scheduling in the specification?


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:2050
     propagateFPControl(team);
+#if OMPD_SUPPORT
+    if (ompd_state & OMPD_ENABLE_BP)
----------------
We already have program points defined for OMPT callbacks.
Isn't it better to place parallel begin/end BP at the places near OMPT parallel begin/end?
Are there any missing parallel begin/end not covered by the current OMPT parallel begin/end?


================
Comment at: openmp/runtime/src/ompd-specific.cpp:40
+
+int ompd_rtl_version = 7;
+
----------------
Can you add some comments why it is 7.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100181/new/

https://reviews.llvm.org/D100181