[Openmp-commits] [PATCH] D99656: [AMDGPU][OpenMP] Enable Libomptarget runtime tests

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

In D99656#2716049 <https://reviews.llvm.org/D99656#2716049>, @pdhaliwal wrote:

> With properly configured cmake and lit, it should be possible to add tests run separately for architectures. For e.g. it should be possible to create targets like check-libomptarget-amdgcn-amd-amdhsa which would run tests only for amdgcn and similar for others. These can be grouped under existing check-libomptarget.

I posted D101315 <https://reviews.llvm.org/D101315> and D101326 <https://reviews.llvm.org/D101326>. I suggest that you rebase on these two patches. This should cut down the necessary changes for your patch.

You might want to mark unsupported tests with `// XFAIL: amdgcn-amd-amdhsa` (currently failing, but will be fix in future) or `// UNSUPPORTED: amdgcn-amd-amdhsa` (no plan to support the test)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99656/new/

https://reviews.llvm.org/D99656