[Openmp-commits] [PATCH] D101315: [OpenMP][libomptarget][test] Separate lit tests for different offloading targets

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Apr 26 11:23:55 PDT 2021


protze.joachim created this revision.
protze.joachim added reviewers: pdhaliwal, JonChesterfield, tianshilei1992.
protze.joachim added a project: OpenMP.
Herald added subscribers: guansong, yaxunl, mgorny.
protze.joachim requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

This patch creates a separate test directory for each offloading target to be tested. 
This allows to test multiple architectures in one configuration, while still see all failing tests separately.
The lit test names include the target triple, so that it will be easier to spot the failing target.

The new %...-generic substitutions are preferred over the specialized rules. The specialized rules should only be used, if different action is required for different targets. I only updated `mapping/private_mapping.c` to demonstrate the necessary change.

This patch also allows to mark expected failing tests based on the target-triple, the currently used triple is added to the "features":

  %XFAIL: target-triple


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101315

Files:
  openmp/libomptarget/test/CMakeLists.txt
  openmp/libomptarget/test/lit.cfg
  openmp/libomptarget/test/lit.site.cfg.in
  openmp/libomptarget/test/mapping/private_mapping.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101315.340590.patch
Type: text/x-patch
Size: 6198 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20210426/e76a57a2/attachment-0001.bin>


More information about the Openmp-commits mailing list