[Openmp-commits] [PATCH] D99656: [AMDGPU][OpenMP] Enable Libomptarget runtime tests

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Apr 26 00:23:21 PDT 2021


protze.joachim added a comment.

In D99656#2661379 <https://reviews.llvm.org/D99656#2661379>, @JonChesterfield wrote:

> I guess there's no XFAIL equivalent here? In that case we should probably leave off the RUN line for the tests that can't work, as they'll otherwise break the build once an amdgpu CI machine goes live

It's a general problem of the current libomptarget tests. A test fails if any of the run lines fails and will not check the remaining lines. 
I think, it would be better to run the tests individually for each available target. Would it be possible to run the test for each supported target in a different work directory?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99656/new/

https://reviews.llvm.org/D99656



More information about the Openmp-commits mailing list