[Openmp-commits] [PATCH] D100774: [OpenMP] Add function for setting LIBOMPTARGET_INFO at runtime

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

In D100774#2709750 <https://reviews.llvm.org/D100774#2709750>, @jhuber6 wrote:

> Seems reasonable. I'd probably have another function that returns a reference to the internal atomic variable, then `getInfoLevel()` just returns the value inside the atomic.

Sounds good.

In D100774#2709750 <https://reviews.llvm.org/D100774#2709750>, @jhuber6 wrote:

> Should this be a another review? Or a revert + fix.

I don't think anything is broken here so would suggest another patch + review on top, leaving this in place. Plus that way if the header only version doesn't work out so well we still have this fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100774/new/

https://reviews.llvm.org/D100774