[Openmp-commits] [PATCH] D100774: [OpenMP] Add function for setting LIBOMPTARGET_INFO at runtime

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

Surprising amount of code here, probably because it changes from one function to some code * number plugins.

Was the idea to allow directly writing to `static uint32_t InfoLevel = 0;`, which is inconvenient when it's a static function? If so, that is still achievable in header only fashion without adding global variables to program scope, e.g. by returning a reference from getInfoLevel and adding a setter function, or going with a detail function that is called by the getter and setter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100774/new/

https://reviews.llvm.org/D100774