[Openmp-commits] [PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: clang/lib/Headers/openmp_wrappers/__clang_openmp_device_functions.h:20
+// need to `include <new>`.
+#include <new>
+#endif
----------------
jdoerfert wrote:
> JonChesterfield wrote:
> > I think there are legitimate use cases for writing code that doesn't include new. Can we add the forms that are meant to be available without the include here, instead of just pulling in all new?
> Hm, what forms would you not like to see in the code by default, and why?
> 
I would prefer the default includes exactly the expressions/syntax that C++ provides by default, which may mean writing some inline here though I'm perplexed that we need to do something different to clang compiling c++. I'd have to look up which operators are magic and which are in the header.

At least some reluctance is that we don't have a gpu <new>, so this will be whatever host libstdc++/libc++ is in use, and I'd like to avoid including gpu-unaware code on the gpu wherever possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100620/new/

https://reviews.llvm.org/D100620