[Openmp-commits] [PATCH] D99803: [openmp] Add OMPT initialization in libomptarget

[Lechen Yu via Phabricator via Openmp-commits]

lechenyu added inline comments.


================
Comment at: openmp/libomptarget/src/interface.cpp:312-314
+#if OMPT_SUPPORT
+
+#endif
----------------
grokos wrote:
> Remove
I have removed it in the new diff


================
Comment at: openmp/libomptarget/src/ompt-target.h:12
+// callbacks to libomptarget. The structs' definitions should be in sync with
+// the definitions in libomptarget/src/ompt_internal.h
+
----------------
grokos wrote:
> `ompt_internal.h` resides under `runtime/src/`, not `libomptarget/src/`.
This file no longer needs "ompt-internal.h" in the updated diff. For omp-tools.h, I have added LIBOMP_INCLUDE_DIR into LIBOMPTARGET_LLVM_INCLUDE_DIRS (at openmp/libomptarget/src/CMakeLists.txt:25).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99803/new/

https://reviews.llvm.org/D99803