[Openmp-commits] [PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: clang/lib/Headers/openmp_wrappers/__clang_openmp_device_functions.h:20
+// need to `include <new>`.
+#include <new>
+#endif
----------------
I think there are legitimate use cases for writing code that doesn't include new. Can we add the forms that are meant to be available without the include here, instead of just pulling in all new?


================
Comment at: clang/test/Headers/Inputs/include/cstdlib:5
 
+void *malloc(size_t);
+void free(void*);
----------------
These are in stdlib just above, no? Possibly with noexcept tags


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100620/new/

https://reviews.llvm.org/D100620