[Openmp-commits] [PATCH] D100600: [OpenMP] Add info for device table changes

[George Rokos via Phabricator via Openmp-commits]

grokos added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:267
     uintptr_t tp = (uintptr_t)allocData(Size, HstPtrBegin);
-    DP("Creating new map entry: HstBase=" DPxMOD ", HstBegin=" DPxMOD ", "
-       "HstEnd=" DPxMOD ", TgtBegin=" DPxMOD "\n",
-       DPxPTR(HstPtrBase), DPxPTR(HstPtrBegin),
-       DPxPTR((uintptr_t)HstPtrBegin + Size), DPxPTR(tp));
+    INFO(OMP_INFOTYPE_ALL, DeviceID,
+         "Creating new map entry with "
----------------
Do you really want to use `OMP_INFOTYPE_ALL` here? Upon removal of elements, we use `OMP_INFOTYPE_CHANGED`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100600/new/

https://reviews.llvm.org/D100600