[Openmp-commits] [PATCH] D99803: [openmp] Add OMPT initialization in libomptarget

[George Rokos via Phabricator via Openmp-commits]

grokos added inline comments.


================
Comment at: openmp/libomptarget/src/ompt-target.h:12
+// callbacks to libomptarget. The structs' definitions should be in sync with
+// the definitions in libomptarget/src/ompt_internal.h
+
----------------
`ompt_internal.h` resides under `runtime/src/`, not `libomptarget/src/`.


================
Comment at: openmp/libomptarget/src/rtl.cpp:80
+    }
+    ompt_initialized = true;
+  }
----------------
If the call to `start_tool` failed, is it correct to claim that ompt is initialized? On the other hand, maybe it's enough that you've set `ompt_target_enabled` to 0.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99803/new/

https://reviews.llvm.org/D99803