[Openmp-commits] [PATCH] D100181: [OpenMP] [OMPD] [1/6] Implementation of OMPD debugging library - libompd. Code changes in openmp/runtime to support libompd.

Vignesh Balasubramanian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sun Apr 11 23:48:30 PDT 2021


Vigneshbalu added inline comments.


================
Comment at: openmp/runtime/src/kmp_csupport.cpp:644
 
+  serial_team->t.t_level--;
   if (__kmp_env_consistency_check)
----------------
jdoerfert wrote:
> Here and elsewhere, if a change is not guarded by OMPD_SUPPORT, it seems to me they should be committed separately. 
I have guarded other places,  this change and  "openmp/runtime/src/ompt-specific.cpp" are code movement that stems from https://github.com/OpenMPToolsInterface/llvm-project/commit/45e69d3a5fc27af7bf92ed5310987eb25070e538 . 
I will create separate review for this.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100181/new/

https://reviews.llvm.org/D100181



More information about the Openmp-commits mailing list